Remove EquationConstraint #757
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Instead, use dedicated constraints, since they can resolve faster.
![sourcery-ai[bot]](https://github.com/avatars/in/48477?s=60&v=4){kind=small}
There was a problem hiding this comment.
PR Type: Refactoring
PR Summary: The pull request removes the EquationConstraint class from the gaphas library and updates the associated documentation and tests. The intent is to streamline the constraint solving process by using dedicated constraints that can resolve faster, potentially improving the performance of the library.
Decision: Comment
📝 Type: 'Refactoring' - not supported yet.
- Sourcery currently only approves 'Typo fix' PRs.
✅ Issue addressed: this change correctly addresses the issue or implements the desired feature.
No details provided.
✅ Small diff: the diff is small enough to approve with confidence.
No details provided.
General suggestions:
- Ensure that the removal of EquationConstraint is clearly communicated in the release notes, especially if it's part of the public API, to inform users about the change and any necessary migration steps.
- Verify that the new or modified constraints that replace EquationConstraint maintain the same functionality or provide a clear improvement, to justify the removal of the existing feature.
- Consider providing a deprecation path if the EquationConstraint was widely used, to ease the transition for existing users of the library.
Thanks for using Sourcery. We offer it for free for open source projects and would be very grateful if you could help us grow. If you like it, would you consider sharing Sourcery on your favourite social media? ✨
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Type
What kind of change does this PR introduce?
What is the new behavior?
Instead, use dedicated constraints, since they can resolve faster.
Does this PR introduce a breaking change?
Other information