Add to arrays function #462
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
d-kad
commented
Jul 15, 2024
d-kad
commented
- Add to_arrays method to Game class that takes as its input an array-like object of array-like objects produces a Gambit game object with a strategic form representation.
- Add tests for the above method
- Docstring for the new function is added
tturocy
requested changes
Jul 16, 2024
d-kad
force-pushed
the
add-to-arrays-function
branch
2 times, most recently
from
57e5a85
to
ec628ab
Compare
tturocy
requested changes
Jul 18, 2024
d-kad
force-pushed
the
add-to-arrays-function
branch
2 times, most recently
from
d7654b4
to
afcd5dc
Compare
tturocy
requested changes
Jul 19, 2024
d-kad
force-pushed
the
add-to-arrays-function
branch
from
afcd5dc
to
4c0b3fb
Compare
tturocy
requested changes
Jul 31, 2024
d-kad
force-pushed
the
add-to-arrays-function
branch
from
4c0b3fb
to
c2e02ce
Compare
tturocy
requested changes
Aug 20, 2024
There was a problem hiding this comment.
Just one small suggestion in the docs, otherwise looking good.
The last remaining thing to do is to squash the commits down to one commit with a good commit message - see e.g. https://cbea.ms/git-commit/ for some nice habits on this. Also, add an entry as appropriate in the ChangeLog file.
d-kad
force-pushed
the
add-to-arrays-function
branch
5 times, most recently
from
0632e81
to
208ba06
Compare
d-kad
force-pushed
the
add-to-arrays-function
branch
from
208ba06
to
c4d752f
Compare
…ike object of array-like objects produces a Gambit game object with a strategic form representation. Add tests for the above method Add docstring for the new function index on add-to-arrays-function: b1b801f Add to_arrays function
d-kad
force-pushed
the
add-to-arrays-function
branch
from
c4d752f
to
c6fbded
Compare
tturocy
approved these changes
Aug 30, 2024
|
The commit history of this has gotten garbled enough that I have manually re-done it and committed as cc7c97e. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.