-
Notifications
You must be signed in to change notification settings - Fork 149
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add to arrays function #462
Conversation
d-kad
commented
Jul 15, 2024
- Add to_arrays method to Game class that takes as its input an array-like object of array-like objects produces a Gambit game object with a strategic form representation.
- Add tests for the above method
- Docstring for the new function is added
57e5a85
to
ec628ab
Compare
d7654b4
to
afcd5dc
Compare
afcd5dc
to
4c0b3fb
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just a few minor polish items, quite close now.
4c0b3fb
to
c2e02ce
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just one small suggestion in the docs, otherwise looking good.
The last remaining thing to do is to squash the commits down to one commit with a good commit message - see e.g. https://cbea.ms/git-commit/ for some nice habits on this. Also, add an entry as appropriate in the ChangeLog
file.
0632e81
to
208ba06
Compare
208ba06
to
c4d752f
Compare
…ike object of array-like objects produces a Gambit game object with a strategic form representation. Add tests for the above method Add docstring for the new function index on add-to-arrays-function: b1b801f Add to_arrays function
c4d752f
to
c6fbded
Compare
The commit history of this has gotten garbled enough that I have manually re-done it and committed as cc7c97e. |