Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: fixes freezing when creating synced patterns #3245

Merged
merged 9 commits into from
Jul 16, 2024

Conversation

mxkae
Copy link
Contributor

@mxkae mxkae commented Jul 15, 2024

fixes #3229 #3226

Copy link

github-actions bot commented Jul 15, 2024

🤖 Pull request artifacts

file commit
pr3245-stackable-3245-merge.zip d48bc17

github-actions bot added a commit that referenced this pull request Jul 15, 2024
Copy link
Contributor

@bfintal bfintal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This fix is great but it looks like we need to do this across all style components across all block-components and blocks. For example, we'll need to create memos for the Style component in the Video Popup block

github-actions bot added a commit that referenced this pull request Jul 15, 2024
src/block/timeline/edit.js Outdated Show resolved Hide resolved
github-actions bot added a commit that referenced this pull request Jul 15, 2024
@andeng1106
Copy link

andeng1106 commented Jul 16, 2024

@mxkae @bfintal These items still has issue with stylings:

  • Image block
    • Stylings doesn't show on frontend
    • When copying from WP 6.6 to WP 6.5, it causes a block error
  • Separator
    • Stylings for the main separator doesn't show on frontend

github-actions bot added a commit that referenced this pull request Jul 16, 2024
github-actions bot added a commit that referenced this pull request Jul 16, 2024
@bfintal bfintal merged commit 16947b5 into develop Jul 16, 2024
1 of 6 checks passed
@bfintal bfintal deleted the fix/3229-wp6.6-synced-patterns branch July 16, 2024 15:15
github-actions bot added a commit that referenced this pull request Jul 16, 2024
mxkae added a commit that referenced this pull request Jul 22, 2024
bfintal pushed a commit that referenced this pull request Jul 22, 2024
* Revert "fix (performance): fixes freezing when creating and adding synced patterns in WP 6.6 (#3245)"

This reverts commit 16947b5.

* add timeout in useEffect
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants