fix: corrected variable name that causes empty media queries #3243
Conversation
🤖 Pull request artifacts
|
|
@Arukuen Media Query is still not working on my end. Is there any steps I need to take to see the fix? 🤔 Screen.Recording.2024-07-15.at.9.17.38.AM.mov |
|
For the Media Query, we should use |
This is now working 😄 |
src/dynamic-breakpoints.php
Outdated
| @@ -32,6 +32,9 @@ function __construct() { | |||
| add_action( 'rest_api_init', array( $this, 'register_settings' ) ); | |||
|
|
|||
| if ( is_frontend() && $this->has_custom_breakpoints() ) { | |||
| // Add a filter for replacing shortcut media queries before the breakpoint adjustment. | |||
| add_filter( 'stackable_frontend_css', array( $this, 'replace_shortcut_media_queries' ) ); | |||
There was a problem hiding this comment.
Filters need to be assigned.
e.g.
$new_value = add_filter( 'filter_name', 'old_value' );There was a problem hiding this comment.
@bfintal Isn't this for apply_filter function? My goal here is to add a filter that replace the shortcut media queries before the breakpoint adjustment.
|
@Arukuen Fix for shortcut media query is not yet working on my end. Is there something I need to do to make it work? 🤔 Screen.Recording.2024-07-17.at.7.mp4 |
|
@andeng1106 Have you tried also adding the fix from Premium? |
@Arukuen Apologies for adding the comment here this PR. Yes, I'm using PR #354 in the video. What I did so far:
|
|
@andeng1106 The implementation for the editor comes from the premium PR, while the one for the frontend is from this PR. Based on the video, it seems like it is only working on the editor, and I think it's because the PR are tested separately. If that's the case, here is a build that contains code for both PR. |
|
@Arukuen The build you provided shows the fix now. Thanks! |
fixes #3214