Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: adjust classes and styles of variation picker for wp 6.6 #3234

Merged
merged 3 commits into from
Jul 13, 2024

Conversation

Arukuen
Copy link
Contributor

@Arukuen Arukuen commented Jul 7, 2024

fixes #3219

Opted to adapt to newer variation picker style. Some style are overwritten to accommodate picker for Stackable blocks:

  1. Add margin similar to old version for longer label and compatibility.
  2. Make fill of premium variations lighter

Copy link

github-actions bot commented Jul 7, 2024

🤖 Pull request artifacts

file commit
pr3234-stackable-3234-merge.zip d2f0250

github-actions bot added a commit that referenced this pull request Jul 7, 2024
@Arukuen
Copy link
Contributor Author

Arukuen commented Jul 7, 2024

Old:
Screenshot 2024-07-07 140105

New:
Screenshot 2024-07-07 134440

@andeng1106
Copy link

andeng1106 commented Jul 11, 2024

@Arukuen Fixed on WP 6.6. One remaining issue:

  • Due to the fix, on WP 6.2, the disabled Premium layouts looks like this now:
    • Issue only for WP 6.2
Screenshot 2024-07-11 at 2 06 42 PM

github-actions bot added a commit that referenced this pull request Jul 11, 2024
@bfintal
Copy link
Contributor

bfintal commented Jul 12, 2024

@andeng1106 please re-check, I adjusted the styles. The icons were also missing

github-actions bot added a commit that referenced this pull request Jul 12, 2024
@andeng1106
Copy link

@bfintal @Arukuen
The icons are showing on my end but it's now Grey instead of our color. Is this okay? 🤔

New PR build:
Screenshot 2024-07-12 at 4 08 33 PM

Previous PR build:
Screenshot 2024-07-12 at 4 08 44 PM

@Arukuen
Copy link
Contributor Author

Arukuen commented Jul 12, 2024

@andeng1106
This is intentional to adapt to WP 6.6, which greyed out the variation picker for native blocks (eg. Native Column).

@bfintal bfintal merged commit c4c940b into develop Jul 13, 2024
1 of 6 checks passed
@bfintal bfintal deleted the fix/3219-layout-picker branch July 13, 2024 15:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[WP 6.6] Layout Picker follows the new Layout Picker UI but looks off
3 participants