fix: display theme fonts in font picker #3227
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🤖 Pull request artifacts
|
bfintal
requested changes
Jul 2, 2024
bfintal
reviewed
Jul 10, 2024
bfintal
requested changes
Jul 10, 2024
src/fonts.php
Outdated
|
|
||
| function __construct() { | ||
| if ( is_frontend() ) { | ||
| add_action( 'init', array( $this, 'gather_theme_fonts' ) ); |
There was a problem hiding this comment.
We can optimize this area. Checking the code, looks like this init action is only needed to load all the fonts once so we can have a local list of what all the fonts are.. then this list is only needed by the is_theme_font function.
I recommend deleting this add_action since it's just an initializer, and instead call gather_theme_fonts directly inside the function is_theme_font when it's needed. We can also only do the gather once.
Suggestion:
// Change the default value to `false` so we know when it's not yet initialized
public static $theme_fonts = false;
public static function gather_theme_fonts() {
if ( self::$theme_fonts !== false ) {
return self::$theme_fonts;
}
self::$theme_fonts = [];
// Proceed with the original function...
return self::$theme_fonts;
}
public static function is_theme_font( $font_name ) {
return in_array( strtolower( $font_name ), self::gather_theme_fonts() );
}
src/fonts.php
Outdated
Comment on lines
71
to
80
| if ( ! method_exists( 'WP_Font_Face_Resolver', 'get_fonts_from_theme_json' ) ) { | ||
| return false; | ||
| } | ||
|
|
||
| $theme_fonts = WP_Font_Face_Resolver::get_fonts_from_theme_json(); | ||
|
|
||
| $response = array(); | ||
| foreach ( $theme_fonts as $key => $value ) { | ||
| $response[] = $value[ 0 ][ 'font-family' ]; | ||
| } |
There was a problem hiding this comment.
Looks like this is doing the same thing as gather_theme_fonts except returning it as a REST response. Maybe we can combine for DRY code
…kable into fix/3195-get-block-theme-fonts # Conflicts: # src/fonts.php
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #3195