Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: bring bottom separator to back of content #3190

Merged
merged 3 commits into from
Jul 11, 2024

Conversation

mxkae
Copy link
Contributor

@mxkae mxkae commented May 22, 2024

fixes #3061

Copy link

github-actions bot commented May 22, 2024

🤖 Pull request artifacts

file commit
pr3190-stackable-3190-merge.zip e4f45a3

github-actions bot added a commit that referenced this pull request May 22, 2024
@andeng1106
Copy link

@mxkae Remaining issue:

  • When I enable Bottom Separator for Feature and Feature Grid block, it looks glitchy on editor.
    • Issue on editor only
    • Issue started to happen on this pr build
Screen.Recording.2024-06-24.at.5.mp4

github-actions bot added a commit that referenced this pull request Jun 25, 2024
Copy link
Contributor

@bfintal bfintal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why did we pick z-index 5 here?

github-actions bot added a commit that referenced this pull request Jul 10, 2024
@mxkae
Copy link
Contributor Author

mxkae commented Jul 10, 2024

Why did we pick z-index 5 here?

z-index 5 was used in this fix but z-index 3 also works for me. Updated it for now to use z-index 3.

@bfintal bfintal merged commit f3b1026 into develop Jul 11, 2024
1 of 6 checks passed
@bfintal bfintal deleted the fix/3061-bottom-separator-2 branch July 11, 2024 09:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bottom Separator not going to the back of content
3 participants