-
Notifications
You must be signed in to change notification settings - Fork 998
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow OAuth 2.0 user defined file sources (w/Dropbox integration) #18272
Open
jmchilton
wants to merge
10
commits into
galaxyproject:dev
Choose a base branch
from
jmchilton:oauth2_user_file_sources_dev
base: dev
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Allow OAuth 2.0 user defined file sources (w/Dropbox integration) #18272
jmchilton
wants to merge
10
commits into
galaxyproject:dev
from
jmchilton:oauth2_user_file_sources_dev
+2,963
−454
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jmchilton
added
area/UI-UX
kind/feature
area/API
area/auth
Authentication and authorization
labels
May 30, 2024
jmchilton
force-pushed
the
oauth2_user_file_sources_dev
branch
from
May 31, 2024 13:04
2ba6a75
to
d8339fe
Compare
jmchilton
force-pushed
the
oauth2_user_file_sources_dev
branch
6 times, most recently
from
June 12, 2024 14:42
7ddf7db
to
b02e537
Compare
jmchilton
force-pushed
the
oauth2_user_file_sources_dev
branch
3 times, most recently
from
June 19, 2024 15:16
bdb037e
to
8a93354
Compare
jmchilton
force-pushed
the
oauth2_user_file_sources_dev
branch
from
July 9, 2024 14:35
8a93354
to
8df6893
Compare
This is very cool! Let me know when it's ready and I'd be happy to do some testing. |
jmchilton
force-pushed
the
oauth2_user_file_sources_dev
branch
2 times, most recently
from
July 9, 2024 15:51
b15652c
to
62137df
Compare
jmchilton
force-pushed
the
oauth2_user_file_sources_dev
branch
7 times, most recently
from
September 27, 2024 16:04
94a0cc8
to
ab70f15
Compare
- UI for detailed display of errors. - UI option to test configuration from management menu. - API + UI for checking configuration before upgrading to new version of template. - API + UI for checking configuration before updating current template's settings. - Add an option during update/upgrade to allow forcing the update even if configuration doesn't validate - I don't allow creation of invalid things, but if there are problems with an existing thing - admins and power users should have recourse. It is their data.
jmchilton
force-pushed
the
oauth2_user_file_sources_dev
branch
2 times, most recently
from
September 27, 2024 17:49
e66c9cb
to
b2033a4
Compare
jmchilton
force-pushed
the
oauth2_user_file_sources_dev
branch
from
September 27, 2024 19:41
b2033a4
to
cbbd223
Compare
…ile redirecting to the file source provider in `FileSources/CreateInstance`
… and show errors in `CreateUserFileSource` Co-authored-by: David López <46503462+davelopez@users.noreply.github.com>
): | ||
if error: | ||
error_code = self._ensure_valid_oauth_error_code(error) | ||
return RedirectResponse(f"{trans.request.url_path}{ERROR_REDIRECT_PATH}?error={error_code}") |
Check warning
Code scanning / CodeQL
URL redirection from remote source Medium
Untrusted URL redirection depends on a .
user-provided value
Error loading related location
Loading
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Builds on #18222 (only the last commit is relevant to this PR beyond that one currently).
This implements oauth2 client capabilities with the user defined file sources framework. There would be some work to integrate this with user defined object stores also but that would be pretty minimal given the code overlap/shared abstractions used on the client and server.
This works currently more or less but I want to make sure it works with Scope requesting clients and on a second service so I going to wait until I've integrated a Google Drive plugin and documented that before taking it out of Draft/WIP.
This work integrates an initial oauth2 enabled plugin for Dropbox including admin documentation for how to configure it and how build and configure a Dropbox app within Dropbox for a Galaxy instance.
Documentation Screenshot
Documentation Screenshot
Documentation Screenshot
For oauth2 services - the plugin status framework has been updated to reflect some additional information. Hopefully we can use it down the road to know when refresh tokens need to be re-requested and such though nothing beyond initial creation and typical use is implemented here so far:
How to test the changes?
(Select all options that apply)
http://localhost:8081/oauth2_callback
in my local testing with themake client-dev-server
proxy.License