-
Notifications
You must be signed in to change notification settings - Fork 796
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: eth_callMany #2664
base: master
Are you sure you want to change the base?
feat: eth_callMany #2664
Conversation
|
||
#[derive(Serialize, Debug, Clone)] | ||
pub struct EthCallManyBalanceDiff { | ||
pub balance: U256, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'd like to have this as Option, in case we need more fields
Going to update as per code review comments |
Updated PR as per code review comments - added 2 basic examples |
#[derive(Serialize, Deserialize, Debug, Clone)] | ||
pub struct EthCallManyOutputEmpty {} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
redundant type?
#[derive(Serialize, Deserialize, Debug, Clone)] | ||
pub struct EthCallManyOutput { | ||
pub value: Option<Bytes>, | ||
pub error: Option<EthCallManyOutputEmpty>, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this should be a string
can we get a sample response for a test? |
overrides object lacks some fields I believe: |
Motivation
Missing feature, I had written it initially for my own project using (erigontech/erigon#4471) as reference and thought I would implement it here
Solution
Add eth_callMany function to support simulating a set of bundles
PR Checklist