Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use tracing for logging #32

Closed
gakonst opened this issue Jun 21, 2020 · 1 comment · Fixed by #113
Closed

Use tracing for logging #32

gakonst opened this issue Jun 21, 2020 · 1 comment · Fixed by #113
Labels
enhancement New feature or request v1

Comments

@gakonst
Copy link
Owner

gakonst commented Jun 21, 2020

Is your feature request related to a problem? Please describe.
A clear and concise description of what the problem is. Ex. I'm always frustrated when [...]

Currently the library offers no logging.

Describe the solution you'd like

Tracing provides great logging support with various levels of verbosity along with contexts, instead of using println calls. Example of past integration:

celo-org/snark-setup#44
celo-org/snark-setup#43
@gakonst gakonst added the enhancement New feature or request label Jun 21, 2020
@gakonst
Copy link
Owner Author

gakonst commented Sep 25, 2020

This can be implemented as a LoggerMiddleware

@gakonst gakonst added the v1 label Dec 1, 2020
@gakonst gakonst mentioned this issue Dec 24, 2020
Merged
@gakonst gakonst mentioned this issue Apr 7, 2021
Closed
meetmangukiya pushed a commit to meetmangukiya/ethers-rs that referenced this issue Mar 21, 2022
@mattsse
chore: cargo --fix (gakonst#32)
dc5d793
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request v1
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat(providers): add tracing gakonst/ethers-rs
1 participant
@gakonst