Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support ESLint 8.x #495

Closed
MichaelDeBoey opened this issue Aug 29, 2021 · 3 comments
Closed

Support ESLint 8.x #495

MichaelDeBoey opened this issue Aug 29, 2021 · 3 comments

Comments

@MichaelDeBoey
Copy link
Contributor

MichaelDeBoey commented Aug 29, 2021

ESLint v8.0.0 is released 🎉

It would be awesome to have official ESLint 8 support. 👊
I'm happy to help where I can of course 🙂

@EvHaus
Copy link

EvHaus commented Oct 14, 2021

Looks like the plugin doesn't support it out-of-the-box. Trying to use it with eslint@8.0.1 gives me this:

ESLint: 8.0.1

Error [ERR_PACKAGE_PATH_NOT_EXPORTED]: Package subpath './lib/rules/no-unused-expressions' is not defined by "exports" in /myproject/node_modules/eslint/package.json
    at throwExportsNotFound (internal/modules/esm/resolve.js:299:9)
    at packageExportsResolve (internal/modules/esm/resolve.js:522:3)
    at resolveExports (internal/modules/cjs/loader.js:449:36)
    at Function.Module._findPath (internal/modules/cjs/loader.js:489:31)
    at Function.Module._resolveFilename (internal/modules/cjs/loader.js:875:27)
    at Function.Module._load (internal/modules/cjs/loader.js:745:27)
    at Module.require (internal/modules/cjs/loader.js:961:19)
    at require (/myproject/node_modules/v8-compile-cache/v8-compile-cache.js:159:20)
    at Object.<anonymous> (/myproject/node_modules/eslint-plugin-flowtype/dist/rules/noUnusedExpressions.js:8:51)
    at Module._compile (/myproject/node_modules/v8-compile-cache/v8-compile-cache.js:192:30)

@MichaelDeBoey
Copy link
Contributor Author

@EvHaus That's why I created #496 😉

@EvHaus
Copy link

EvHaus commented Oct 27, 2021

Upgrading the eslint-plugin-flowtype@8.0.2 fixed my issue. Thank you!

@gajus gajus closed this as completed Oct 27, 2021
sounisi5011 added a commit to sounisi5011/npm-packages that referenced this issue Dec 20, 2021
+ `@react-native-community/eslint-config@^2.0.0` does not work

    This includes `eslint-plugin-flowtype@^7.0.0` for dependencies.
    However, `eslint-plugin-flowtype@^7.0.0` does not work with ESLint 8.
    [This has been fixed in version `8.0.2`], but `@react-native-community/eslint-config@^2.0.0` does not use this.

[This has been fixed in version `8.0.2`]: gajus/eslint-plugin-flowtype#495
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants