feat: Add support for "Prefer Cross-Fade Transitions" into AccessibilityInfo #2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gabrieldonadel
force-pushed
the
feat/add-prefer-crossfade-transitions
branch
2 times, most recently
from
c67d0b0
to
2ec98a0
Compare
gabrieldonadel
commented
Jan 27, 2022
Comment on lines
79
to
84
| if (@available(iOS 14.0, *)) { | ||
| [[NSNotificationCenter defaultCenter] addObserver:self | ||
| selector:@selector(prefersCrossFadeTransitionsStatusDidChange:) | ||
| name:UIAccessibilityPrefersCrossFadeTransitionsStatusDidChangeNotification | ||
| object:nil]; | ||
| } |
There was a problem hiding this comment.
This is not working as expected, UIAccessibilityPrefersCrossFadeTransitionsStatusDidChangeNotification never gets triggered. Best option might be just removing it for now and reading UIAccessibilityPrefersCrossFadeTransitions() directly
I've opened a question in Apple's Developer Forums reporting this issue https://developer.apple.com/forums/thread/699257
gabrieldonadel
force-pushed
the
feat/add-prefer-crossfade-transitions
branch
from
2ec98a0
to
be79058
Compare
gabrieldonadel
force-pushed
the
feat/add-prefer-crossfade-transitions
branch
2 times, most recently
from
37e71c6
to
8127d3a
Compare
gabrieldonadel
changed the title
gabrieldonadel
force-pushed
the
feat/add-prefer-crossfade-transitions
branch
from
8127d3a
to
8bf2aa9
Compare
gabrieldonadel
force-pushed
the
feat/add-prefer-crossfade-transitions
branch
from
8bf2aa9
to
71632b4
Compare
gabrieldonadel
force-pushed
the
feat/add-prefer-crossfade-transitions
branch
from
4ee496c
to
ff3802d
Compare
gabrieldonadel
force-pushed
the
feat/add-prefer-crossfade-transitions
branch
from
ff3802d
to
5c81481
Compare
|
tracked on https://github.com/facebook/react-native/pull/ 34406 |
gabrieldonadel
pushed a commit
that referenced
this pull request
Sep 8, 2022
Summary: VirtualizedList would more gracefully handle out of range cells than VirtualizedList_EXPERIMENTAL, which treats it as an invariant violation. D39244112 (facebook@7aa203b) attempted to fix an issue where recalculation of cells around viewport can include out of range cells, but it is still showing up later. This change adds a bounds check to the remaining branch we control, and an assertion that `computeWindowedRenderLimits` is not returing something out of range to discover if that is the cause. Reviewed By: yungsters Differential Revision: D39267445 fbshipit-source-id: 64c99da28b5b01ef61784079b586e355f73764a1
gabrieldonadel
pushed a commit
that referenced
this pull request
Dec 20, 2023
Summary: Pull Request resolved: facebook#41466 ## Context In open source, all apps use the same turbomodulemanager delegate (i.e: the default delegate). This diff introduces the buck infra that makes the oss default delegate work for meta apps. Concretely, we are going to make React Native use the same delegate for **all** Meta apps. Each Meta app will: 1. At build time, generate a unique TMProvider map 2. At app init time, initialize the default delegate with the TMProvider map. ## Implementation **Step #1:** At build time, generate a unique TMProvider map **Insight:** Buck genrules can accept, as input, the output of a buck query. So, here's how we get this done: 1. Buck query (i.e: input to Genrule): Given the app's deps, query all the schemas in the app. 2. Genrule: Read the schemas to generate the TMProvider map. The TMProvider map will also contain **all** the app's C++ module codegen. Concretely: 1. This diff introduces a macro: rn_codegen_appmodules(deps). 2. rn_codegen_appmodules(deps) generates appmodules.so, which contains the TMProvider map. **Step #2:** At app init time, initialize the default delegate with the TMProvider map. This is how we'll initialize the DefaultTurboModuleManagerDelegate: 1. DefaultTurboModuleManagerDelegate will load appmodules.so during init. 2. When loaded, appmodules.so will assign the code-generated TMProvider map to DefaultTurboModuleManagerDelegate. ## Impact This should allow us to: 1. Get one step closer to getting rid of the `js1 build turbomodule-manager-delegates --target <app>` script 3. Remove the TurboModuleManagerDelegate from React Native's public API. (Because we use one delegate for all React Native apps in Meta and OSS) Changelog: [Internal] Reviewed By: mdvacca Differential Revision: D50988397 fbshipit-source-id: 0ca5dec14e2dae89ec97f5d39a182c7937c5c7bf
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR adds
prefersCrossFadeTransitionsto AccessibilityInfo in other to add support for "Prefer Cross-Fade Transitions", exposing the iOS settings option as proposed here https://github.com/react-native-community/discussions-and-proposals/issues/. 452.I believe this would be especially helpful for solving facebook#31484
TODO
Changelog
[iOS] [Added] - Add support for "Prefer Cross-Fade Transitions" into AccessibilityInfo
Test Plan
On iOS 14+