Add 2 more options for decoding CBOR integers to interface{}
#457
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
x448
reviewed
Dec 28, 2023
x448
reviewed
Dec 28, 2023
x448
reviewed
Dec 28, 2023
x448
approved these changes
Dec 28, 2023
Added 2 new decoding options to IntDecMode which specifies how to
decode CBOR integers (major type 0 and 1) to Go interface{}.
- IntDecConvertSignedOrFail makes CBOR integers decode to:
* int64 if value fits
* return UnmarshalTypeError if value doesn't fit into int64
- IntDecConvertSignedOrBigInt makes CBOR integers decode:
* int64 if value fits
* big.Int or *big.Int if value doesn't fit into int64
Including default setting (IntDecConvertNone), there are
now 4 options for decoding CBOR unsigned or CBOR negative
integers into interface{}.
Deprecated IntDecConvertSigned option in favor of other options
for more consistent handling of values that don't git into int64.
Also updated comments for existing IntDecMode options.
fxamacker
force-pushed
the
fxamacker/add-option-to-IntDecMode
branch
from
863358d
to
b5a6ef0
Compare
fxamacker
changed the title
interface{}
|
Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #438
Added 2 new decoding options to
IntDecModewhich specifies how to decode CBOR integers (major type 0 and 1) to Go interface{}.IntDecConvertSignedOrFailmakes CBOR integers decode to:UnmarshalTypeErrorif value doesn't fit into int64IntDecConvertSignedOrBigIntmakes CBOR integers decode:big.Intor*big.Intif value doesn't fit into int64Including
IntDecConvertNone(default setting), there are now 4 options for decoding CBOR unsigned or CBOR negative integers into interface{}.Deprecated
IntDecConvertSignedoption in favor of other options for more consistent handling of values that don't git into int64.Also updated comments for existing
IntDecModeoptions.Default behavior is unchanged to maintain backward compatibility.