Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor valid() to reject negative values for integer modes #434

Merged
merged 1 commit into from
Nov 5, 2023

Conversation

fxamacker
Copy link
Owner

For modes of integer type, make valid() reject negative values since 0 is default and non-negative values are used.

Also reformat comments with gofmt.

Special thanks to @benluddy for adding this check in PR #432 for a new setting. Basically, this PR does the same check as PR #432 for all other settings of integer type.

For modes of integer type, make valid() reject negative values
since 0 is default and non-negative values are used.

Also reformat comments with gofmt.
@fxamacker fxamacker added the improvement improvement that does not add new feature label Nov 5, 2023
@fxamacker
Copy link
Owner Author

@x448 PTAL

Copy link
Contributor

@x448 x448 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@fxamacker fxamacker merged commit ad0cc0c into master Nov 5, 2023
17 checks passed
@fxamacker fxamacker added this to the v2.6.0 milestone Nov 12, 2023
@fxamacker fxamacker deleted the fxamacker/refactor-option-valid-check branch December 28, 2023 21:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
improvement improvement that does not add new feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants