Bump safer-golangci-lint to 1.52.2 #408
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Bump golangci-lint to 1.52.2. Bump Go to 1.20.
Remove deprecated linters. Temporarily disable revive to reduce noise in golangci-lint 1.52.2.
|
At a glance, the revive linter errors look like noise, so I pushed a commit to your PR to disable the linter in the config file. While at it, also disabled deprecated linters. I need to wait until weekend to look more closely into the revive linter errors. |
fxamacker
approved these changes
May 18, 2023
Specify DDR4 in benchmark system because faster RAM (DDR5 or overclocked DDR4) makes a difference in this specific comparison.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Bump golangci-lint to 1.52.2.
Bump Go to 1.20.
@fxamacker The PR template should include CI config to the same exception used for contributing docs: