Add decoding option to allow invalid UTF-8 #342
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add DecOptions.UTF8 to specify how to decode invalid UTF-8: - UTF8RejectInvalid (default) returns SemanticError on invalid UTF-8 - UTF8DecodeInvalid decodes invalid UTF-8 Since CBOR text containing invalid UTF-8 isn't valid, decoder by default rejects it and returns error. This option is backward compatible by default. See RFC 8949 Section 5.3 (Validity of Items) for more info.
|
@x448 This is a port from stream-mode branch. Can you review in case I missed anything? |
x448
approved these changes
May 15, 2022
fxamacker
deleted the
fxamacker/add-decode-option-for-invalid-utf8-in-nonstreammode
branch
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add DecOptions.UTF8 to specify how to decode invalid UTF-8:
Since CBOR text containing invalid UTF-8 isn't valid, decoder by default
rejects it and returns error.
This option is backward compatible by default.
See RFC 8949 Section 5.3 (Validity of Items) for more info.
Closes #320