Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test epub #1284

Draft
wants to merge 18 commits into
base: master
Choose a base branch
from
Draft

Test epub #1284

wants to merge 18 commits into from

Conversation

kmacshane
Copy link

No description provided.

//KEM: add in a load to the smil file and append it?
request(this.url)
.then(function (xml) {
// var directory = new Url(this.url).directory;

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The main change in section is that instead of loading just the page url, I also load the smil file first and then feed the result into where it loads the main page, in order to append it onto the iframe html.

item.href = manifestItem.href;
item.url = resolver(item.href, true);
item.canonical = canonical(item.href);

if(manifestItem.properties.length){
//KEM: added overlay so can load later in section
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The change here is to load the smil information from the manifest into the saved list of items that keeps track of the page urls and properties. Now the smil will be associated with the page, and this is used later in section.js when the page is loaded and displayed.

return manifest[key];
});

this.replacementUrls = [];

this.html = [];
//KEM: assets and urls are where the urls in items from the manifest are replaced by "blobs"
this.assets = [];
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There's no changes to resources.js other than beautification, but because the audio files are erroring I think the fix will be in how it replaces the URLs in the replacements() function.

@@ -1,4 +1,4 @@
import {qs, qsa, qsp, indexOfElementNode} from "./utils/core";
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No changes, this is just beautification modification from my editor.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant