Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update faculty.js to work with new image sourceUrl values #150

Open
JesseRWeigel opened this issue Aug 2, 2018 · 1 comment
Open

Update faculty.js to work with new image sourceUrl values #150

JesseRWeigel opened this issue Aug 2, 2018 · 1 comment

Comments

@JesseRWeigel
Copy link
Contributor

This issue has been fixed in wp-graphql wp-graphql/wp-graphql#468

Now it will be easier to get the urls for all image sizes. We no longer need the regex to create image urls in faculty.js

@JesseRWeigel
Copy link
Contributor Author

For now I reverted back to a previous version of faculty.js that works, but does not use srcset. Ideally we would use sreset, but this will work for now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant