Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Makefile installs unnecessary dependencies in python. #13

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

fukuchancat
Copy link

try:
import jaconv
except ImportError:
pip.main(['install', 'jaconv'])
import jaconv" | python3
# neologdのmecab形式から、juman形式の辞書に変換
# また、文字数の多すぎるエントリや、絵文字、顔文字等の記号を排除
# 半角から全角への変換も実施
python3 ${binary_path}/codes/neologd2juman.py < $1 > ./${input_base}.dic

In neologd2juman.sh, python3 is called, not python.

In most cases, the package management system that supports python3 is considered to be pip3. pip supports python.

pip install -r requirements.txt

Therefore, the Makefile in this project uses pip, which I think installs an unnecessary dependency in python.
I think it should be changed to pip3 to properly install in python3.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant