Makefile installs unnecessary dependencies in python. #13
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
neologd2juman/neologd2juman.sh
Lines 52 to 61 in de72e6a
In neologd2juman.sh,
python3
is called, notpython
.In most cases, the package management system that supports
python3
is considered to bepip3
.pip
supportspython
.neologd2juman/Makefile
Line 2 in de72e6a
Therefore, the Makefile in this project uses
pip
, which I think installs an unnecessary dependency inpython
.I think it should be changed to
pip3
to properly install inpython3
.