Add AsyncSeq.mapAsyncUnorderedParallel #157
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
My first contribution |
Xyncgas
changed the title
dsyme
reviewed
Oct 27, 2022
dsyme
reviewed
Oct 27, 2022
| @@ -0,0 +1,24 @@ | |||
| using System.Threading.Channels; | |||
| namespace Helper | |||
There was a problem hiding this comment.
Any reason why this helper can't be written in F#?
dsyme
reviewed
Oct 27, 2022
| let inline (|AbsPosRangeByLength|_|) (start,length) = if start >= GenericZero && length > GenericZero then Some (start,length) else None | ||
| let inline private AsyncSequenceProduce (dataChannel:Channel<'a>) producer source = | ||
| async{ | ||
| let Mutex = new Mutex(); |
There was a problem hiding this comment.
Feels like this should be using https://learn.microsoft.com/en-us/dotnet/api/system.threading.interlocked.increment?view=net-6.0?
|
@Xyncgas I left some initial comments - we'd need tests too. Any reason this doesn't go direct into the main library? |
I didn't want to put stuff into the folder but created a separate one because I didn't know what to do |
|
@abelbraaksma Should we close this old one out? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I implemented mapAsyncUnorderedParallel
Can someone please help me to add it into the AsyncSeq library we are using