Rename toList/toArray to toListSynchronously/toArraySynchronously

[blumu]

Calling Async.RunSynchronously in libraries is error-prone and can cause dead-locks. (e.g. when running on the main interactive thread.) I would just remove the two functions toList and toArray altogether to prevent library users from hitting hard-to-debug issues.

FSharp.Control.AsyncSeq/src/FSharp.Control.AsyncSeq/AsyncSeq.fs

Line 1317 in 9b608ff

let toList (source:AsyncSeq<'T>) = toListAsync source |> Async.RunSynchronously

FSharp.Control.AsyncSeq/src/FSharp.Control.AsyncSeq/AsyncSeq.fs

Line 1318 in 9b608ff

let toArray (source:AsyncSeq<'T>) = toArrayAsync source |> Async.RunSynchronously

[dsyme]

It's true, though I certainly remember using these when playing around with AsyncSeq, testing and so on. Perhaps renaming to toListSynchronously and and toArraySynchronously may be right for now?

[eulerfx]

I'd second the rename. I agree that use of Async.RunSynchronously is troublesome and that these operations conceal it (particularly from a code quality scanner).