Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BuildState with message #2139

Merged
merged 14 commits into from
Oct 13, 2018
Merged

Conversation

BlythMeister
Copy link
Contributor

@BlythMeister BlythMeister commented Oct 10, 2018

Description

  • Update BuildState to include a string option for a message
  • Update all listeners to work with new TraceData

This should not be considered a breaking change since the code itself states that changing TraceData is not considered a breaking change.

/// Note: Adding new cases to this type is not considered a breaking change!
/// Please consider not using a match on this type in code external to the fake repository.

Extends #2138 to prevent later conflicts on the TeamCity code so includes all commits from that PR.

@matthid
Copy link
Member

matthid commented Oct 11, 2018

The build is red an I noticed
image

apparently we shouldn't trace processes used for ci messages...

@BlythMeister
Copy link
Contributor Author

Did I cause that...

@BlythMeister BlythMeister changed the title Trace ProblemReport & BuildState with message BuildState with message Oct 12, 2018
@BlythMeister
Copy link
Contributor Author

Oh I see the error, I backed a bit out...and missed this.

@matthid
Copy link
Member

matthid commented Oct 12, 2018

Can you please merge latest (build should be green again)?
I guess I should open my own PRs such that release/next is always green :/

@BlythMeister
Copy link
Contributor Author

Hehe, it will have to wait until monday. I've not got access to my laptop until then

@matthid
Copy link
Member

matthid commented Oct 13, 2018

Ok, maybe I'm trying to help by sending a pr to your branch, last time I tried merging directly it looked weird in the pr...

@matthid
Copy link
Member

matthid commented Oct 13, 2018

(I'm also trying to debug why azure pipelines are red on all prs with this)

@BlythMeister
Copy link
Contributor Author

I guess worst case, you could create a pr off the head of my branch and enhance like you did with the nunit one?

@matthid
Copy link
Member

matthid commented Oct 13, 2018

@BlythMeister not sure if you meant that but I already opened BlythMeister#2

@BlythMeister
Copy link
Contributor Author

Merged...I hope

@matthid
Copy link
Member

matthid commented Oct 13, 2018

@BlythMeister almost... let me try again with BlythMeister#3 :)

Try again, now hopefully all is green ;)
@BlythMeister
Copy link
Contributor Author

Merged again 😂

@matthid
Copy link
Member

matthid commented Oct 13, 2018

Lol now the diff apparently fixed itself and is now small again oO did you do things differently this time?

@BlythMeister
Copy link
Contributor Author

I choose merge...not rebase

@matthid
Copy link
Member

matthid commented Oct 13, 2018

Thanks for helping out, now stuff is green again :)

@BlythMeister
Copy link
Contributor Author

Wooooo

@matthid
Copy link
Member

matthid commented Oct 13, 2018

Will send a pr for all your open prs, go through all of them and start the 5.9 release

@matthid matthid merged commit 6b9e62e into fsprojects:release/next Oct 13, 2018
@matthid
Copy link
Member

matthid commented Oct 13, 2018

looks good, thanks!

@BlythMeister BlythMeister deleted the FailureTrace branch July 9, 2021 07:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants