Fix #869

[sliepie]

Fix for #869, a double \\ is added to outputpath param
Did also some cleanup and fix of warnings.

What is the indention to use for Fake? Parts of this file are indented with 2 spaces, and other parts with 4 spaces.

[matthid]

Yes lets try that, thanks!

[theimowski]

This seems to break older versions of mono, for
XBuild Engine Version 14.0
Mono, Version 4.6.1.0

xbuild tries to copy assemblies to a path with a backslash:

Copying file from '$BUILD_DIR/packages/NUnit/lib/nunit.framework.dll' to '$BUILD_DIR/test\nunit.framework.dll'

and fails to do so because that's a unix box.

I'm using MSBuild.runRelease helper, how can I workaround that?

[sliepie]

@theimowski
You can workaround this by specifying the outpath as a msbuild property, using the MSBuild.runReleaseExt helper as such:

let props = [ "OutputPath", outputPath ]
MSBuild.runReleaseExt setParams null props targets projects

[theimowski]

Thanks, the workaround with MSBuild.runReleaseExt works fine for me.
What's the reason the backslash is added to the OutputPath parameter anyway?

[sliepie]

@theimowski MSBuild expects that OutputPath ends with a (back)slash. If you pass a path without a slash at the end, MSBuild substitutes paths without a slash in between.
When you expected C:\Build\Project\bin\Example the result would be C:\Build\Project\binExample

I've opened #2020 as tracking issue.