feat: inspect log scrolling #13
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
LumaKernel
commented
Mar 11, 2022
•
LumaKernel
commented
🦋 Changeset detectedLatest commit: 780b1f1 The changes in this PR will be included in the next version bump. Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
real{width, height}の安定性強化含む。 |
Merged
LumaKernel
commented
Mar 11, 2022
| <Text color="gray" italic> | ||
| {left} | ||
| </Text> | ||
| <Box width={wcwidth(text) - (text.length - stringLength(text))}> |
There was a problem hiding this comment.
こいつの解説。
length は Unicode 文字何個分か。wcwidth は見た目の幅。stringLength は "文字" 何個か。
'\x00'.length === 1wcwidth('\x00') === 0stringLength('\x00') === 1// ここは疑問だがまあいい'a'.length === 1wcwidth('a') === 1stringLength('a') === 1'あ'.length === 1wcwidth('あ') === 2// ターミナルの表示上で2文字分stringLength('あ') === 1// "文字" としては 1 文字'😁'.length === 2// サロゲートペア使っているので Unicode文字 2 分wcwidth('😁') === 2stringLength('😁') === 1
ink 君は length が stringLength より多いと多めに幅を確保してしまいます。多分バグです。絵文字で問題出ます。とりえあえず width で上から抑えます。
絵文字の増えた分を吸収するには全部使ってやっと検知できます。 (制御文字は問題でますが、これは ANSI コンテキスト側で解決予定です）
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.