Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch workflows to new EKS runners #1362

Closed
9 tasks done
demisx opened this issue Apr 10, 2023 · 6 comments
Closed
9 tasks done

Switch workflows to new EKS runners #1362

demisx opened this issue Apr 10, 2023 · 6 comments
Assignees
Labels
ci Continuous integration tech debt

Comments

@demisx
Copy link
Collaborator

demisx commented Apr 10, 2023

The new runners have been successfully tested with Verify PR workflow. We need to initiate the switch.

Tasks:

Blocked by:

@demisx demisx self-assigned this Apr 10, 2023
demisx added a commit that referenced this issue Apr 11, 2023
# Goal
The goal of this PR is to switch Verify PR workflow to the new EKS
runners upon successful testing.

Part of #1362
@demisx demisx added tech debt ci Continuous integration labels Apr 12, 2023
@demisx demisx added the blocked Blocked by another issue label May 1, 2023
@demisx
Copy link
Collaborator Author

demisx commented May 1, 2023

While testing release workflow on the new EKS runners, I’ve run into this error in “Build Deterministic WASM” job that also exists on main and will pop-up next time someone cuts a release:

error: failed to run custom build command for `polkadot-runtime v0.9.36 (https://github.com/paritytech/polkadot?branch=release-v0.9.36#dc25abc7)`

Caused by:
  process didn't exit successfully: `/build/runtime/frequency/target/srtool/production/build/polkadot-runtime-f8cb2ea1fb20adc3/build-script-build` (exit status: 1)
  --- stderr
  Rust nightly not installed, please install it!

The failed job is “Build Deterministic WASM” : https://github.com/LibertyDSNP/frequency/actions/runs/4853427916/jobs/8650492538

We need #1449 to be resolved first. Also, per @saraswatpuneet and @wilwade, upgrading the polkadot version should include updating rust and toolchain if needed.

demisx added a commit that referenced this issue May 8, 2023
# Goal
The goal of this PR is switch Merge PR workflow to the new EKS runners.

Part of #1362
@demisx
Copy link
Collaborator Author

demisx commented May 17, 2023

Another error that may be resolved by #1449:

The “Install Subwasm” step currently fails in CI Release workflow with this error:

error[E0658]: sym operands for inline assembly are unstable
--> /root/.cargo/registry/src/github.com-1ecc6299db9ec823/wasmtime-runtime-6.0.1/src/trampolines/x86_64.rs:139:13
|
139 | sym $libcall_impl
| ^^^^^^^^^^^^^^^^^
|
::: /root/.cargo/registry/src/github.com-1ecc6299db9ec823/wasmtime-runtime-6.0.1/src/libcalls.rs:146:5
|
146 | wasmtime_environ::foreach_builtin_function!(libcall);
| ---------------------------------------------------- in this macro invocation
|
= note: see issue #93333 rust-lang/rust#93333 for more information
= help: add #![feature(asm_sym)] to the crate attributes to enable
= note: this error originates in the macro wasm_to_libcall_trampoline which comes from the expansion of the macro wasmtime_environ::foreach_builtin_function (in Nightly builds, run with -Z macro-backtrace for more info)

Here is the failed job: https://github.com/LibertyDSNP/frequency/actions/runs/5006563355/jobs/8972114967

@demisx
Copy link
Collaborator Author

demisx commented Jun 15, 2023

Ran test v0.0.1-rc2 release on 1362-switch-release-workflow-to-eks-runners branch and it failed in "Compare Metadata" job:
https://github.com/LibertyDSNP/frequency/actions/runs/5273222689/jobs/9537174166

@demisx
Copy link
Collaborator Author

demisx commented Jun 15, 2023

Per @wilwade, he will attempt to fix this error on main. Waiting until then to re-run test release.

wilwade added a commit that referenced this issue Jun 15, 2023
# Goal
The goal of this PR is to upgrade the polkadotjs tools for metadata
comparison.

Closes #1230 

This also includes PR #1601 for expediency. So also part of #1362

Ended up needing to run each one in a docker container with a new docker
network. This allowed everything to talk correctly.

# Checklist
- [x] Tested with: make start + docker run --rm --platform=linux/amd64
--pull always jacogr/polkadot-js-tools:0.55.3 metadata
wss://1.rpc.frequency.xyz ws://host.docker.internal:9944
- [x] Tested with test release Running:
https://github.com/LibertyDSNP/frequency/actions/runs/5282806513

---------

Co-authored-by: Dmitri <4452412+demisx@users.noreply.github.com>
@demisx demisx removed the blocked Blocked by another issue label Jul 17, 2023
@demisx
Copy link
Collaborator Author

demisx commented Jul 17, 2023

Created https://www.pivotaltracker.com/story/show/185631909 story to update runner labels. Waiting on @saisomepalle to respond. Need to coordinate the switch together with #1636.

wilwade pushed a commit that referenced this issue Jul 18, 2023
# Goal
The goal of this PR is to update runner labels to their long-term stable
versions.

Part of #1362
@demisx
Copy link
Collaborator Author

demisx commented Jul 19, 2023

This issue has been completed.

@demisx demisx closed this as completed Jul 19, 2023
shannonwells pushed a commit that referenced this issue Apr 16, 2024
# Goal
The goal of this PR is to upgrade the polkadotjs tools for metadata
comparison.

Closes #1230 

This also includes PR #1601 for expediency. So also part of #1362

Ended up needing to run each one in a docker container with a new docker
network. This allowed everything to talk correctly.

# Checklist
- [x] Tested with: make start + docker run --rm --platform=linux/amd64
--pull always jacogr/polkadot-js-tools:0.55.3 metadata
wss://1.rpc.frequency.xyz ws://host.docker.internal:9944
- [x] Tested with test release Running:
https://github.com/LibertyDSNP/frequency/actions/runs/5282806513

---------

Co-authored-by: Dmitri <4452412+demisx@users.noreply.github.com>
shannonwells pushed a commit that referenced this issue Apr 16, 2024
# Goal
The goal of this PR is to update runner labels to their long-term stable
versions.

Part of #1362
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ci Continuous integration tech debt
Projects
None yet
Development

No branches or pull requests

1 participant