You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
The base_fee is not static and can change when we run overhead benchmarks.
Acceptance Criteria:
Ensure that the base_extrinsic weight does not change for Capacity transactions.
Add comment to weight to fee function to warn that it also changes static capacity weights if changed.
Note
Weights for capacity are a
snapshot of weights calculated from benchmarks.
These weights are static and are not updated.
Similarly, we would want to create a constant containing a snapshot of
extrinsic base weight.
…ansactions. (#1455)
# Goal
Ensure that the `base_extrinsic` weight does not change for Capacity
transactions.
Closes#1215
# Discussion
Created a new constant `CAPACITY_EXTRINSIC_BASE_WEIGHT` as a snapshot of
the benchmarks in: `runtime/common/src/weights/extrinsic_weights.rs`.
This change required updates to the unit tests, as this new constant
overrides the `base_extrinsic` in the `mock.rs`, the test accounts
required more tokens to cover the transaction costs.
# Checklist
- [ ] Chain spec updated
- [ ] Custom RPC OR Runtime API added/changed? Updated js/api-augment.
- [ ] Design doc(s) updated
- [ ] Tests added
- [ ] Benchmarks added
- [ ] Weights updated
---------
Co-authored-by: Matthew Orris <--help>
Description
Capacity transactions are meant to be stable and not affected by network congestion.
Additionally, unlike token transactions, capacity transactions
do not allow tipping or multiplying the weight
fee by a targeted_fee_adjustment.
The fee for a capacity transaction:
fee = base_fee + length_fee + weight_fee
----- ^^^^
----- ^^^^
The base_fee is not static and can change when we run overhead benchmarks.
Acceptance Criteria:
Note
Weights for capacity are a
snapshot of weights calculated from benchmarks.
These weights are static and are not updated.
Similarly, we would want to create a constant containing a snapshot of
extrinsic base weight.
@wilwade check
The text was updated successfully, but these errors were encountered: