update MADR #473
Merged
update MADR #473
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
stash86
commented
Aug 17, 2024
stash86
commented
- Add option to use different MA than SMA
- change sma and std into variables instead of a dataframe columns, so no need to drop them later
xmatthias
reviewed
Aug 17, 2024
technical/indicators/indicators.py
Outdated
| else: | ||
| df["stdcenter"] = ta.SMA(df.rate, timeperiod=(length * stds)) | ||
|
|
||
| std = ta.STDDEV(df.rate, timeperiod=(length * stds)) |
There was a problem hiding this comment.
maybe use std_series here instead?
std and stds is VERY similar - so i had to double-check what's what ... (same for ma, really).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.