-
Notifications
You must be signed in to change notification settings - Fork 218
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
the zema written here is actually DEMA #356
Conversation
Is this removal due to the tests you've been doing about the difference between running that indicator against a small vs. a big dataframe? I'm not against that if that's the reason - just would want some clarity. (it's also used in another function - so right now, everything is broken ...) |
yes, I first noticed it when I do the recursive test. The difference of DEMA and this zema are identical for all lengths. So I checked investopedia for DEMA's formula, and found that current zema is actually DEMA |
I'm not sure that's actually the case though (please read to the end - zema is still not correct). the formula according to your link is the "2x" part is missing - and the signs are also different. That said - i can't find a definition for zema matching the implementation, either. Which is however NOT corresponding to the implementation at hand, which appears to be something random. |
It's the same actually.
can be re-arranged into
|
I'm gonna remove all references to zema and replace it wth dema |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍
remove zema, and use ta-lib DEMA