Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix map link in custom banner #464

Closed
wants to merge 1 commit into from
Closed

fix map link in custom banner #464

wants to merge 1 commit into from

Conversation

maurerle
Copy link
Collaborator

Before, this produced URLs like https://map.ffmuc.net/#!{NODEID} which do not work

@maurerle maurerle requested a review from grische July 10, 2024 14:12
@maurerle maurerle requested a review from a team as a code owner July 10, 2024 14:12
@T0biii
Copy link
Member

T0biii commented Jul 10, 2024

z.B. https://map.ffmuc.net/#!/4682d327ec74 works for me fine

@grische
Copy link
Contributor

grische commented Jul 10, 2024

@maurerle works on my machine

Copy link
Contributor

@grische grische left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We do not want to bias the default language of the link.
Works for both ffmuc and ffac. Examples:

@T0biii
Copy link
Member

T0biii commented Jul 10, 2024

ah i see in your Site file: ffac/site@cc608e0
there was a missing / at the end

@T0biii T0biii closed this Jul 10, 2024
@maurerle maurerle deleted the banner-link-map branch July 10, 2024 17:11
@maurerle
Copy link
Collaborator Author

Thanks! :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants