Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

domains: add Wertingen domains #266

Merged
merged 1 commit into from
Nov 6, 2023
Merged

domains: add Wertingen domains #266

merged 1 commit into from
Nov 6, 2023

Conversation

grische
Copy link
Contributor

@grische grische commented Oct 31, 2023 •
edited
Loading

This is a proposal for the new wertingen domains. See #243

cc @freifunkMUC/salt-stack @istrator2

@grische grische added backport legacy Backport to Legacy Branch backport next Backport to Next Branch labels Oct 31, 2023
@grische grische mentioned this pull request Oct 31, 2023
Closed
istrator2
istrator2 reviewed Oct 31, 2023
View reviewed changes
Copy link
Contributor

@istrator2 istrator2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Compared to ffmuc_augsburg.conf in next_node section there is no name and no mac specified. By intention?

@grische
Copy link
Contributor Author

grische commented Oct 31, 2023

mac has been deprecated for a few years and should not be used for new domains.
name, from what I understood, is optional as well and our value seems to be pretty randomly chosen.

@grische
Copy link
Contributor Author

grische commented Nov 2, 2023

I confirmed that the domain does not show up in config mode (until we have ensured it works), but it can be switched manually:

root@testnode:~# gluon-switch-domain 'dummy'
Error: invalid mesh domain 'dummy'
root@testnode:~# gluon-switch-domain 'ffwert_city'
client_loop: send disconnect: Connection reset by peer

@grische grische marked this pull request as ready for review November 2, 2023 11:00
@grische grische requested a review from a team as a code owner November 2, 2023 11:00
@grische grische changed the title domains: add wertingen domains domains: add Wertingen domains Nov 2, 2023
@grische
Copy link
Contributor Author

grische commented Nov 2, 2023

Rebased and added back next_node.name as this seem to have some effect on our side.

@grische grische added the stable label Nov 3, 2023
@grische grische merged commit 7714d2f into freifunkMUC:stable Nov 6, 2023
27 checks passed
@github-actions GitHub Actions
Copy link

github-actions bot commented Nov 6, 2023

Successfully created backport PR for legacy:

This was referenced Nov 6, 2023
Closed
Merged
@github-actions GitHub Actions
Copy link

github-actions bot commented Nov 6, 2023

Successfully created backport PR for next:

@grische grische deleted the feature/ffwert_domains branch November 6, 2023 18:33
@grische grische added this to the v2023.12.1 milestone Dec 4, 2023
@grische grische mentioned this pull request Apr 6, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@awlx awlx awlx approved these changes

@istrator2 istrator2 istrator2 approved these changes

Assignees
No one assigned
Labels
backport legacy Backport to Legacy Branch backport next Backport to Next Branch stable
Projects
None yet
Milestone
v2023.12.1 - FFDon and FFWert support
Development

Successfully merging this pull request may close these issues.
3 participants
@grische @awlx @istrator2