Rename packages-folder #766
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
the commits have been around in this branch for some time, but I did not make a PR out of them before :-) Why postponing? Currently there ist the problem, that "git status" complains on untracked files in "packages" as soon as "make prepare" was called. |
SvenRoederer
added a commit
that referenced
this pull request
Mar 10, 2020
|
The build of this branch was successful on my machine, but i didn't test the images. |
|
thanks for a separate test, quite sure the images are fine, as the imagebuilder is called with the same arguments. I'd like to merge this soon. |
SvenRoederer
added a commit
that referenced
this pull request
Apr 10, 2020
Akira25
approved these changes
Apr 12, 2020
|
let's agree on squashing the 1st and the last into one and keep the other two separate, as they don't strictly belong to the folder-renaming. |
|
Okay. I'm fine with that. |
When we started to use some code of the gluon framework a minor conflict of the usage of the packages-folder came up. We use it to store the package-lists for our images, Gluon uses this folder to store the upstream repos. By this double-use there are always the repos inside the folder and causing git to report them as untracked files. Adding the folder to .gitignore is also no option, as we need it for our package-lists. So just lets move our files and adjust .gitignore.
SvenRoederer
force-pushed
the
rename_packages
branch
from
8f6cd28
to
d94cf45
Compare
As it's used to store the upstream-repos which don't need tracking.
SvenRoederer
force-pushed
the
rename_packages
branch
from
d94cf45
to
aff82c1
Compare
SvenRoederer
added a commit
to SvenRoederer/freifunk-berlin-firmware
that referenced
this pull request
Apr 26, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rename the folder "packages" to "packagelists". This change will