FS-495 Avoid flattening lists of parameters #496
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
juanpedromoreno
approved these changes
Jan 9, 2018
| object Y extends X.Handler[Id] { | ||
| def a: Int = 5 | ||
| } | ||
| //X[X.Op].b.interpret[Id] shouldEqual 10 |
There was a problem hiding this comment.
Is this comment useful?
There was a problem hiding this comment.
No, it's a typo. It should be a line to run the derived b method with the Y Handler.
We modify the `@free` macro, to ensure that we do not flatten the lists of parameters.
diesalbla
force-pushed
the
FS-Retain_Parameters_Lists_Shapes
branch
from
4a1a452
to
9d2e1e3
Compare
juanpedromoreno
approved these changes
Jan 10, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #495.
We modify the
@freemacro, to avoid mixing or flattening separate lists of parameters.We increase test coverage for
@freeprograms these programs. We avoid usingshould compilein these tests.