This repository has been archived by the owner on Jul 3, 2020. It is now read-only.
WIP: First stab at git post-commit hook #9
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Note that the code in this branch is very similar to that in the recently added |
The post-commit hook parses the state of the code after each commit to the `master` branch, builds a tree of method definition "files" using ri-style naming, and adds a corresponding commit to the orphan `method-log` branch. * This code assumes the `method-log` branch already exists. * I've not thought about what happens if the history on `master` is re-written. * There is no explicit reference between the commits on `master` and those on the `method-log` branch. * I'm not sure how tenable it is to use a `Gemfile` and bundler for this hook. Maybe an in-line `Gemfile` [1] might be better. * I've duplicated some code from elsewhere in the repo, e.g. `#unindent`. * I've used `instance_variable_get` on the instance of `MethodFinder`, but it would be easy to surface this as a public attribute reader method. [1]: http://bundler.io/whats_new.html#inline
floehopper
force-pushed
the
git-post-commit-hook
branch
from
937ccc2
to
d1ea62d
Compare
|
Rebased against master and force-pushed. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The post-commit hook parses the state of the code after each commit to the
masterbranch, builds a tree of method definition "files" using ri-style naming, and adds a corresponding commit to the orphanmethod-logbranch.This code assumes the
method-logbranch already exists.I've not thought about what happens if the history on
masteris re-written.There is no explicit reference between the commits on
masterand those on themethod-logbranch.I'm not sure how tenable it is to use a
Gemfileand bundler for this hook. Maybe an in-lineGemfilemight be better.I've duplicated some code from elsewhere in the repo, e.g.
#unindent.I've used
instance_variable_geton the instance ofMethodFinder, but it would be easy to surface this as a public attribute reader method.