Run qvm-sync-appmenus on AppVMs #520
Assignees
Labels
Comments
|
It's unclear whether we should be making appmenus available at all in most cases. We should decide what if any menu items are required. |
|
See also #857 which may resolve this issue. |
We decided (and implemented) that all the VMs should be hidden except sd-devices and sd-whonix, which have tools that users may need to manually start. We already run qvm-sync-appmenus for the small and large templates, we just need to do it for whonix. And then set menu items for those two VMs specifically. I'm picking this up now since I need to do it to address #1109, which points out that we've regressed in the menu items for sd-devices. |
legoktm
added a commit
that referenced
this issue
Jun 27, 2024
These are the only two VMs that will be visible on production systems and have specific tools we want users to be able to directly start. * sd-devices: Files (Nautilus) and Disks * sd-whonix: Anon Connection Wizard and Tor Control Panel We already run qvm-sync-appmenus for the sd-large template that sd-devices is based on, copy that logic over for the whonix gateway template that sd-whonix is based on. Since none of the sd-small VMs are displayed in the menu, remove its qvm-sync-appmenus step. Fixes #520. Fixes #1109.
4 tasks
legoktm
added a commit
that referenced
this issue
Jun 27, 2024
These are the only two VMs that will be visible on production systems and have specific tools we want users to be able to directly start. * sd-devices: Files (Nautilus) and Disks * sd-whonix: Anon Connection Wizard and Tor Control Panel We already run qvm-sync-appmenus for the sd-large template that sd-devices is based on, copy that logic over for the whonix gateway template that sd-whonix is based on. Since none of the sd-small VMs are displayed in the menu, remove its qvm-sync-appmenus step. Fixes #520. Fixes #1109.
legoktm
added a commit
that referenced
this issue
Jun 28, 2024
These are the only two VMs that will be visible on production systems and have specific tools we want users to be able to directly start. * sd-devices: Files (Nautilus) and Disks * sd-whonix: Anon Connection Wizard and Tor Control Panel Ideally we would do all of this in salt, but since we need to run stuff via dom0 after we do things in the VMs, it would require adjusting the order of some salt states, which is a bit too intrusive for a fix during the RC/QA period. A TODO indicates that this is not an ideal situation, and <freedomofpress/securedrop-client#2078> tracks one potential fix. Fixes #520. Fixes #1109.
legoktm
added a commit
that referenced
this issue
Jun 28, 2024
These are the only two VMs that will be visible on production systems and have specific tools we want users to be able to directly start. * sd-devices: Files (Nautilus) and Disks * sd-whonix: Anon Connection Wizard and Tor Control Panel Ideally we would do all of this in salt, but since we need to run stuff via dom0 after we do things in the VMs, it would require adjusting the order of some salt states, which is a bit too intrusive for a fix during the RC/QA period. A TODO indicates that this is not an ideal situation, and <freedomofpress/securedrop-client#2078> tracks one potential fix. Fixes #520. Fixes #1109.
legoktm
added a commit
that referenced
this issue
Jun 28, 2024
These are the only two VMs that will be visible on production systems and have specific tools we want users to be able to directly start. * sd-devices: Files (Nautilus) and Disks * sd-whonix: Anon Connection Wizard and Tor Control Panel Ideally we would do all of this in salt, but since we need to run stuff via dom0 after we do things in the VMs, it would require adjusting the order of some salt states, which is a bit too intrusive for a fix during the RC/QA period. A TODO indicates that this is not an ideal situation, and <freedomofpress/securedrop-client#2078> tracks one potential fix. Fixes #520. Fixes #1109.
rocodes
pushed a commit
that referenced
this issue
Jul 3, 2024
These are the only two VMs that will be visible on production systems and have specific tools we want users to be able to directly start. * sd-devices: Files (Nautilus) and Disks * sd-whonix: Anon Connection Wizard and Tor Control Panel Ideally we would do all of this in salt, but since we need to run stuff via dom0 after we do things in the VMs, it would require adjusting the order of some salt states, which is a bit too intrusive for a fix during the RC/QA period. A TODO indicates that this is not an ideal situation, and <freedomofpress/securedrop-client#2078> tracks one potential fix. Fixes #520. Fixes #1109.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Initially reported by @zenmonkeykstop
We run
qvm-sync-appmenusonly twice, and only for two TemplateVMs.securedrop-workstation/dom0/sd-app.sls
Line 60 in f2afb12
securedrop-workstation/dom0/sd-devices.sls
Line 48 in f2afb12
We should consider running this command for AppVMs for which we expect users to navigate to (for example, sd-whonix for anon connection wizard and sd-export for gnome-disks).
It may be best to run it as a separate salt target, so that we can run it during an install but also as part of the dom0 provisioning if required (it requires the VM to be powered on prior to running that command)
Related: #365
The text was updated successfully, but these errors were encountered: