Sd mismatch issue, make Sd value to lower case in dbOperation() #46
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tim-ywliu
reviewed
Jul 18, 2023
| @@ -1358,6 +1358,42 @@ func dbOperation(ueId string, servingPlmnId string, method string, subsData *Sub | |||
| filterUeIdOnly := bson.M{"ueId": ueId} | |||
| filter := bson.M{"ueId": ueId, "servingPlmnId": servingPlmnId} | |||
|
|
|||
| // Set Sd value to lower case | |||
| if subsData != nil { | |||
There was a problem hiding this comment.
if subsData == nil {
return
}
There was a problem hiding this comment.
It couldn't be returned because the function DeleteSubscriberByID() should call dbOperation() with argument subsData = nil .
tim-ywliu
reviewed
Jul 18, 2023
backend/WebUI/api_webui.go
Outdated
| // Set Sd value to lower case | ||
| if subsData != nil { | ||
| if subsData.AccessAndMobilitySubscriptionData.Nssai != nil { | ||
| if subsData.AccessAndMobilitySubscriptionData.Nssai.DefaultSingleNssais != nil { |
There was a problem hiding this comment.
remove this if, range will skip it if it is nil
tim-ywliu
reviewed
Jul 18, 2023
backend/WebUI/api_webui.go
Outdated
| subsData.AccessAndMobilitySubscriptionData.Nssai.DefaultSingleNssais[i].Sd = strings.ToLower(defaultSingleNssai.Sd) | ||
| } | ||
| } | ||
| if subsData.AccessAndMobilitySubscriptionData.Nssai.SingleNssais != nil { |
There was a problem hiding this comment.
remove this if, range will skip it if it is nil
tim-ywliu
reviewed
Jul 18, 2023
backend/WebUI/api_webui.go
Outdated
| } | ||
| } | ||
| } | ||
| if subsData.SessionManagementSubscriptionData != nil { |
There was a problem hiding this comment.
remove this if, range will skip it if it is nil
tim-ywliu
reviewed
Jul 18, 2023
backend/WebUI/api_webui.go
Outdated
| subsData.SessionManagementSubscriptionData[i].SingleNssai.Sd = strings.ToLower(subscriptionData.SingleNssai.Sd) | ||
| } | ||
| } | ||
| if subsData.SmfSelectionSubscriptionData.SubscribedSnssaiInfos != nil { |
There was a problem hiding this comment.
remove this if, range will skip it if it is nil
tim-ywliu
reviewed
Jul 18, 2023
backend/WebUI/api_webui.go
Outdated
| } | ||
| } | ||
| } | ||
| if subsData.SmPolicyData.SmPolicySnssaiData != nil { |
There was a problem hiding this comment.
remove this if, range will skip it if it is nil
tim-ywliu
reviewed
Jul 18, 2023
backend/WebUI/api_webui.go
Outdated
| if subsData != nil { | ||
| if subsData.AccessAndMobilitySubscriptionData.Nssai != nil { | ||
| if subsData.AccessAndMobilitySubscriptionData.Nssai.DefaultSingleNssais != nil { | ||
| for i, defaultSingleNssai := range subsData.AccessAndMobilitySubscriptionData.Nssai.DefaultSingleNssais { |
There was a problem hiding this comment.
use local var to short whole codes:
defaultSingleNssais := subsData.AccessAndMobilitySubscriptionData.Nssai.DefaultSingleNssais
for i, defaultSingleNssai := range defaultSingleNssais {
defaultSingleNssais[i].Sd = strings.ToLower(defaultSingleNssai.Sd)
}
also modify codes below.
tim-ywliu
reviewed
Jul 20, 2023
backend/WebUI/api_webui.go
Outdated
| } | ||
|
|
||
| smPolicySnssaiDatas := subsData.SmPolicyData.SmPolicySnssaiData | ||
| for i, snssaiData := range smPolicySnssaiDatas { |
There was a problem hiding this comment.
for i := range smPolicySnssaiDatas {
smPolicySnssaiDatas[i].Snssai.Sd = strings.ToLower(smPolicySnssaiDatas[i].Snssai.Sd)
}
tim-ywliu
approved these changes
Jul 20, 2023
tim-ywliu
added a commit
that referenced
this pull request
Aug 11, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is to fix github issue #435