Fixes #308 Include tenant-id when using files api (#1) #346
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Work and test * less change * less * Use file objects and update readme * Feedback * updates * tests * remove * less * cleaner test --------- Co-authored-by: Timbo <tim@agrinous.com>
freakboy3742
requested changes
Nov 3, 2023
tests/test_filesmanager.py
Outdated
| r_get.return_value = None | ||
| try: | ||
| xero.filesAPI.files.all() | ||
| except: # NOQA: E722 |
There was a problem hiding this comment.
This is a bit of a red flag - bare exceptions are flagged by flake8 for a reason; and in this case, I can't see a reason we should be raising an exception at all. As best as I can make out, we just need a more realistic mock return value.
added 2 commits
November 3, 2023 13:51
|
Thanks for reviewing and merging so quickly. Any idea when the next release will be? |
|
There's no reliable release cadence; it's more a case of "when someone asks, or when there's enough of a backlog, whichever happens first" :-) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update the files api manager to include tenant-id in the header - previously would get a 403 using this api.
Updated readme command for running tests.
Added more params for the uploading file so its more inline with existing api and works with different backends (eg S3)