Fix superfluous JSON/XML tagging in PaymentManager #343
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
freakboy3742
approved these changes
Sep 27, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi team,
When testing payment deletions for a feature I am implementing for a live app (batch2sepa), I noticed that the
PaymentManager._delete(self, id)was adding in a wrapping dictionary. This makes the request body get processed as a query encoded string. Xero, granted, fails to parse the body and returns a 500:I only noticed this after checking the app history, making the change in the attached commit leads to the issue being resolved and the payments being deleted correctly.
Let me know if you need any additional information. I hope this will get admitted swiftly!
Kind regards,
Evrim Öztamur