Add 'Tracking' as a plural of 'TrackingCategory' #149
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This feels a bit uncomfortable, but effectively; the Xero API is inconsistent about using 'TrackingCategories' as the key for elements where it expects the sub-elements to be 'TrackingCategory'. Specifically, for LineItems, it uses the term 'Tracking' instead, as per https://developer.xero.com/documentation/api/invoices/ So, this adds 'Tracking' as a "plural" version of "TrackingCategory", to allow inserting line items with tracked options enabled. Without this, creating invoices fails with `PostDataInvalidException: Object reference not set to an instance of an object. []`
|
@aidanlister hey mate, would you have time to review this? We're unable to move to prod without this fix since tracking categories don't work without it. Let me know if I can help in any way, happy to expand/modify as you see fit. |
|
Seems fine, so I'll merge ... but we'll need to redesign this project at some point to implement a specific serializer / deserializer for each endpoint to get away from this type of stuff. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This feels a bit uncomfortable, but effectively; the Xero API is inconsistent about using 'TrackingCategories' as the key for elements where it expects the sub-elements to be 'TrackingCategory'. Specifically, for LineItems, it uses the term 'Tracking' instead, as per https://developer.xero.com/documentation/api/invoices/
So, this adds 'Tracking' as a "plural" version of "TrackingCategory", to allow inserting line items with tracked options enabled. Without this, creating invoices fails with
PostDataInvalidException: Object reference not set to an instance of an object. []