fix: earned leave exceeding annual allocation #397
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Leave Policy with Earned Leave created
Annual Allocation (Leave Policy): 22
Rounding (Leave Type): 1.0
Monthly earned leave = round(22/12) = round(1.83) = 2
2 leaves get allocated for 11 months, so 22 leaves annual allocation is fulfilled
2 more leaves get allocated in the 12th month, making total leaves = 24 (exceeds annual allocation of 22)
Solution
While allocating earned leaves, make sure new allocation without carry forwarded leaves is not exceeding the annual allocation quota.
Excluding carry forwarding allocations in this check is important since users might have carry forwarded leaves + earned leaves annual allocation.
TODO