fix: set party_type null when payment_type is changed to Internal Transfer
#43171
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vishakhdesai
requested review from
deepeshgarg007,
rohitwaghchaure and
ruthra-kumar
as code owners
github-actions
bot
added
accounts
needs-tests
vishakhdesai
force-pushed
the
payment-entry-bug-fix
branch
from
232ffbb
to
502cf0e
Compare
sagarvora
added
backport version-15-hotfix
and removed
needs-tests
sagarvora
added a commit
that referenced
this pull request
Sep 12, 2024
…-43171 fix: set `party_type` null when `payment_type` is changed to `Internal Transfer` (backport #43171)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue while creating Payment Entry for Internal Transfer:
When the Payment Type is changed from Pay to Internal Transfer, the previously set Party Type is not set to null.
Video showing steps to replicate the issue:
Payment.Entry.Issue.mp4