Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(Dunning): logic for fetching text #43160

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from

Conversation

barredterra
Copy link
Collaborator

@barredterra barredterra commented Sep 10, 2024

Before

(a). If the language parameter is provided, return the text for this language. If this doesn't exist, return None.
(b.) If the language parameter is not provided, return the text marked as Is Default Language. If this doesn't exist, return None.

After

  1. If the language parameter is provided, return the text for this language.
  2. If doc.language exists, return the text for this language.
  3. If a text marked as Is Default Language exists, return this one.
  4. Return an empty dict (-> uniform return type)

@github-actions github-actions bot added the needs-tests This PR needs automated unit-tests. label Sep 10, 2024
@barredterra barredterra added backport version-14-hotfix backport to version 14 backport version-15-hotfix and removed needs-tests This PR needs automated unit-tests. labels Sep 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant