Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix : Payment Reco Issue and chart of account importer #38321

Merged
merged 2 commits into from
Nov 26, 2023

Conversation

@github-actions github-actions bot added the needs-tests This PR needs automated unit-tests. label Nov 24, 2023
@Nandhinidevi123 Nandhinidevi123 changed the title Fiix : Payment Reco Issue and chart of account importer fiix : Payment Reco Issue and chart of account importer Nov 24, 2023
@Nandhinidevi123 Nandhinidevi123 changed the title fiix : Payment Reco Issue and chart of account importer fix : Payment Reco Issue and chart of account importer Nov 24, 2023
Copy link

codecov bot commented Nov 24, 2023

Codecov Report

Merging #38321 (86aeacf) into develop (e08d636) will increase coverage by 3.58%.
Report is 2230 commits behind head on develop.
The diff coverage is 63.63%.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop   #38321      +/-   ##
===========================================
+ Coverage    63.69%   67.27%   +3.58%     
===========================================
  Files          813      757      -56     
  Lines        60021    60572     +551     
===========================================
+ Hits         38229    40749    +2520     
+ Misses       21792    19823    -1969     
Files Coverage Δ
.../accounts/doctype/bank_clearance/bank_clearance.py 64.61% <ø> (-3.45%) ⬇️
...of_accounts_importer/chart_of_accounts_importer.py 0.00% <ø> (ø)
...x_withholding_category/tax_withholding_category.py 92.42% <100.00%> (+6.47%) ⬆️
erpnext/controllers/accounts_controller.py 84.84% <100.00%> (-0.40%) ⬇️
erpnext/controllers/queries.py 57.56% <100.00%> (-5.29%) ⬇️
erpnext/crm/doctype/opportunity/opportunity.py 66.81% <100.00%> (ø)
...xt/accounts/doctype/journal_entry/journal_entry.py 69.41% <0.00%> (+0.13%) ⬆️
...t/bank_clearance_summary/bank_clearance_summary.py 0.00% <0.00%> (ø)
erpnext/utilities/bulk_transaction.py 0.00% <0.00%> (-68.82%) ⬇️

... and 318 files with indirect coverage changes

@deepeshgarg007 deepeshgarg007 merged commit d9b3b95 into frappe:develop Nov 26, 2023
15 of 17 checks passed
mergify bot pushed a commit that referenced this pull request Nov 26, 2023
fix : Payment Reco Issue and chart of account importer
(cherry picked from commit d9b3b95)
mergify bot pushed a commit that referenced this pull request Nov 26, 2023
fix : Payment Reco Issue and chart of account importer
(cherry picked from commit d9b3b95)
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jan 5, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
backport version-14-hotfix backport to version 14 backport version-15-hotfix needs-tests This PR needs automated unit-tests.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants