Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add flt() for None type error #38299

Merged
merged 1 commit into from
Nov 23, 2023
Merged

add flt() for None type error #38299

merged 1 commit into from
Nov 23, 2023

Conversation

Nandhinidevi123
Copy link
Contributor

@github-actions github-actions bot added the needs-tests This PR needs automated unit-tests. label Nov 23, 2023
@codecov Codecov
Copy link

codecov bot commented Nov 23, 2023

Codecov Report

Merging #38299 (2a4848e) into develop (e08d636) will increase coverage by 3.57%.
Report is 2208 commits behind head on develop.
The diff coverage is 70.00%.

Additional details and impacted files 
@@             Coverage Diff             @@
##           develop   #38299      +/-   ##
===========================================
+ Coverage    63.69%   67.26%   +3.57%     
===========================================
  Files          813      757      -56     
  Lines        60021    60546     +525     
===========================================
+ Hits         38229    40729    +2500     
+ Misses       21792    19817    -1975
Files Coverage Δ
.../accounts/doctype/bank_clearance/bank_clearance.py 64.61% <ø> (-3.45%) ⬇️
...xt/accounts/doctype/journal_entry/journal_entry.py 69.41% <ø> (+0.13%) ⬆️
...x_withholding_category/tax_withholding_category.py 92.42% <100.00%> (+6.47%) ⬆️
erpnext/controllers/accounts_controller.py 84.84% <100.00%> (-0.40%) ⬇️
erpnext/controllers/queries.py 57.56% <100.00%> (-5.29%) ⬇️
erpnext/crm/doctype/opportunity/opportunity.py 66.81% <100.00%> (ø)
...t/bank_clearance_summary/bank_clearance_summary.py 0.00% <0.00%> (ø)
erpnext/utilities/bulk_transaction.py 0.00% <0.00%> (-68.82%) ⬇️

... and 317 files with indirect coverage changes

@rohitwaghchaure rohitwaghchaure merged commit 64b44a3 into frappe:develop Nov 23, 2023
13 of 14 checks passed
mergify bot pushed a commit that referenced this pull request Nov 23, 2023
@Nandhinidevi123 @mergify
add flt() for None type error (#38299)
eab5836 
(cherry picked from commit 64b44a3)
@mergify mergify bot mentioned this pull request Nov 23, 2023
Merged
rohitwaghchaure pushed a commit that referenced this pull request Nov 23, 2023
@mergify @Nandhinidevi123
add flt() for None type error (backport #38299) (#38306)
30c349b 
add flt() for None type error (#38299)

(cherry picked from commit 64b44a3)

Co-authored-by: NandhiniDevi <95607404+Nandhinidevi123@users.noreply.github.com>
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jan 6, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@deepeshgarg007 deepeshgarg007 Awaiting requested review from deepeshgarg007 deepeshgarg007 is a code owner

@ruthra-kumar ruthra-kumar Awaiting requested review from ruthra-kumar ruthra-kumar is a code owner

Assignees
No one assigned
Labels
backport version-15-hotfix needs-tests This PR needs automated unit-tests.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Nandhinidevi123 @rohitwaghchaure