Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: annual income and expenses in email digest #38273

Merged

Conversation

GursheenK
Copy link
Member

Bug

Email Digest calculates wrong annual income and expense values for a particular fiscal year if the PCV for the previous year has not been submitted.

Income for 2022-2023

Screenshot 2023-11-22 at 6 41 43 PM

Income for 2023-2024

Screenshot 2023-11-22 at 6 41 19 PM

Email Digest sent on a date in the current fiscal year

Screenshot 2023-11-22 at 6 45 09 PM

Fix

Consider GL Entries only from current fiscal year.

@github-actions github-actions bot added accounts needs-tests This PR needs automated unit-tests. labels Nov 22, 2023
@GursheenK GursheenK marked this pull request as ready for review November 24, 2023 09:14
@GursheenK GursheenK merged commit d32147f into frappe:develop Nov 24, 2023
13 checks passed
deepeshgarg007 added a commit that referenced this pull request Nov 24, 2023
…-38273

fix: annual income and expenses in email digest (#38273)
deepeshgarg007 added a commit that referenced this pull request Nov 24, 2023
…-38273

fix: annual income and expenses in email digest (#38273)
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jan 5, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
accounts backport version-14-hotfix backport to version 14 backport version-15-hotfix needs-tests This PR needs automated unit-tests.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant