Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(Timesheet): reset billing hours equal to hours if they exceed actual hours (backport #38134) #38154

Merged

Conversation

mergify[bot]
Copy link
Contributor

@mergify mergify bot commented Nov 17, 2023

This is an automatic backport of pull request #38134 done by Mergify.


Mergify commands and options

More conditions and actions can be found in the documentation.

You can also trigger Mergify actions by commenting on this pull request:

  • @Mergifyio refresh will re-evaluate the rules
  • @Mergifyio rebase will rebase this PR on its base branch
  • @Mergifyio update will merge the base branch into this PR
  • @Mergifyio backport <destination> will backport this PR on <destination> branch

Additionally, on Mergify dashboard you can:

  • look at your merge queues
  • generate the Mergify configuration with the config editor.

Finally, you can contact us on https://mergify.com

@ruchamahabal
Copy link
Member

Unrelated linter failure

@ruchamahabal ruchamahabal merged commit 1e43605 into version-13-hotfix Nov 17, 2023
6 of 7 checks passed
@mergify mergify bot deleted the mergify/bp/version-13-hotfix/pr-38134 branch November 17, 2023 13:03
frappe-pr-bot pushed a commit that referenced this pull request Nov 21, 2023
## [13.54.12](v13.54.11...v13.54.12) (2023-11-21)

### Bug Fixes

* `get_previous_allocation` return value ([6cb8a40](6cb8a40))
* backward compatible query without pluck ([958db77](958db77))
* pass check permission in render_address ([65ae8d9](65ae8d9))
* **Timesheet:** reset billing hours equal to hours if they exceed actual hours (backport [#38134](#38134)) ([#38154](#38154)) ([1e43605](1e43605))
* **Timesheet:** warn user if billing hours > actual hours instead of resetting  (backport [#38239](#38239)) ([#38242](#38242)) ([a9429e1](a9429e1))
* use `get_all` instead of `get_list` ([4b8ed0f](4b8ed0f))

### Performance Improvements

* index most queried fields in Leave Ledger Entry ([eea7bbc](eea7bbc))
* limit rows to 1 for cf leave expiry query ([635c3d5](635c3d5))
@frappe-pr-bot
Copy link
Collaborator

🎉 This PR is included in version 13.54.12 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jan 7, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants