-
Notifications
You must be signed in to change notification settings - Fork 7.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Loyalty Program #12631
Loyalty Program #12631
Conversation
Fantastic contribution, I have been looking out for this function. |
This is long awaited. The request for customer notification is important |
Loyalty points should be a "payment type" On the payment page the total available points should be displayed and the cashier should have the option to use as much of this as the customer wants as tender. The balance will then be taking from the other tender methods |
"Loyalty Program" seems archaic. Use "Loyalty Plan" ? |
Or "Customer Reward Program" |
Hello all Do we have an expected time line for this? anything needed to push it along? Regards |
hi @olamide2 |
We also need to consider the accounting entries for the loyalty transactions. Accounting standard dictates that value of the loyalty earned during a transaction should be treated as a deferred income which will be released when the loyalty is redeemed or expires The following are my proposed entries during a transaction when loyalty is earned or redeemed or both
|
@manassolanki closing this for now. |
Hello Rushabh
Why is this been closed ? I am asking cause I see it is not been merged ?
May I know what the constraints are as this is a much needed feature by us and I have been following it with keen interest.
Regards
-------- Original message --------From: Rushabh Mehta <notifications@github.com> Date: 12/02/2018 08:39 (GMT+01:00) To: frappe/erpnext <erpnext@noreply.github.com> Cc: olamide2 <olamideshodunke@gmail.com>, Mention <mention@noreply.github.com> Subject: Re: [frappe/erpnext] First Cut for the Loyalty Program (#12631)
@manassolanki closing this for now.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub, or mute the thread.
{"api_version":"1.0","publisher":{"api_key":"05dde50f1d1a384dd78767c55493e4bb","name":"GitHub"},"entity":{"external_key":"github/frappe/erpnext","title":"frappe/erpnext","subtitle":"GitHub repository","main_image_url":"https://cloud.githubusercontent.com/assets/143418/17495839/a5054eac-5d88-11e6-95fc-7290892c7bb5.png","avatar_image_url":"https://cloud.githubusercontent.com/assets/143418/15842166/7c72db34-2c0b-11e6-9aed-b52498112777.png","action":{"name":"Open in GitHub","url":"https://github.com/frappe/erpnext"}},"updates":{"snippets":[{"icon":"PERSON","message":"@rmehta in #12631: @manassolanki closing this for now."}],"action":{"name":"View Pull Request","url":"#12631 (comment)"}}}
|
@rmehta Pls we really need this feature like yesterday. Is there any hope for us waiting for this feature to be released? |
@kossanah @olamide2 Sure, it has been closed temporarily and under active development. we have given some feedback to @manassolanki , he will reopen the PR after implementing those. |
d524a2d
to
509cc01
Compare
Glad to see this reopened Important note..we need this to work with PoS module (both offline and on line versions) Regards |
Hello Nabin
Would you mind explaining why this was closed ?
I know there must be a logical reason, but some of us are following this feature extremely closely and would like to know what the status is at each stage.
Regards
null
|
It is still under active development, @manassolanki will soon reopen after finishing the feature. |
0df667e
to
a6e860f
Compare
I think a feature that is so important, required, and of interest to lots of ERPNext users should be given some priority It would really be nice to have some info on the progress (or lack thereof) of this PR and anything we can do to assist in moving things along Cheers |
Awesome! |
@manassolanki |
I'm happy, too. But is there's eta for v11 release?
|
accca18
to
24fd9b6
Compare
2cbfe62
to
5a9d76a
Compare
@manassolanki Travis is failing. Also remove the conflicts. |
71ae956
to
278d92c
Compare
278d92c
to
1043ea1
Compare
Can we merge this already!! lol |
Hi- how can I add loyalty to my erpnext installation on my server? |
Hi- how can I add loyalty to my erpnext installation on my server? We want to have a loyalty program for our customers who walk into a store location and purchase at a pos. this can also extend to the ecommerce purchases |
Hi @drhubehs This is a new feature which hasn't been released in the live version yet. It will be released in version 11. To test it now, you'll have to install the 'develop' branch on your server Since you intend using this in a live environment, I'd advise you wait for version 11 to be released and then update your instance If you would like to discuss this further, you can do that in the forum @ https://discuss.erpnext.com Cheers! :) |
Thanks for the efforts on this. Some issues have been raised on the loyalty points for example check out #14930. Could you also look at making the loyalty available offline based on the suggestions above as quoted below **With regards to the loophole in using loyalty offline, I assume the loophole refers to the ability for the customer to use more points than they are entitled to while the system is offline and throwing the points into negative. In my opinion we should give the retailer the option to assume this risk by using the loyalty module in the offline mode. Some retailers will assume that risk gladly. I will recommend that you put this as an option that the business can activate if they want to assume the risk stated above. What do you think ?** |
@olamide2 I'm testing and notice the same issue as your. I've figured out that the function to calculate tier_name in erpnext\accounts\doctype\loyalty_program\loyalty_program.py, line 60 should be: |
@manassolanki I found another errors in the file: loyalty_point_entry.py function: get_loyalty_point_entries should be: Sorry I don't know how to PR. |
Can you please help update the two errors identified above by @OnlyC ? Regards |
Hi, has anyone been able to migrate loyalty points from previous system into ERPNext without making an Invoice. Businesses have issued Loyalty points on their previous system and these need to be available in production ERPNext. We have tried many ways but not been able to make loyalty points opening. Any help would be much appreciated. |
Note:
Loyalty Program
Loyalty Point Entry/Ledger
Loyalty Point in Customer record
Fixes #12322
Fixes #12790