Bug fixes #210
Merged
Bug fixes #210
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
On windows, query strings in tile server URLs can cause crashes. So catch exceptions in Platform.cpp to protect against bad filenames Tile server URLs with query strings can't be used as a tile disk cache filename. So massage the tileURL to be a legal filename. And change dir separators to underscores to reduce the amount of dir creation disk operations.
In a rotated chart, bottomLeft and topRight corners are not necessarily min and max lat/lon. This can result in too large a search area and overeager filtering out of visible objects. Replace corners passed to maxDensity() and visitNodes() with min and max corners.
Ensure Charts App searches for sibling .json files of charts. By default, borrow Maps App overlayConfig. Update my aircraft location.
|
Thanks for the fixes! There's a tiny merge conflict now after merging #209, it would be great if you could fix that, then I'll merge immediately. |
|
@dave6502, one other thing to be aware of. Before rebuilding Avitab you'll need to update the git submodules as one of the recently added PRs updates the curl libraries to a recent version. I would also recommend to clean and build the 3rd-party libraries, as I have found that some are not very tolerant to a rebuild on top of a previous build. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
3 bug fixes, which have come to light after 0.6.4 release
There is a small amount of overlap with files changed in #209, but I can resubmit if required.