Erase any dangling error messages when objects that report errors are…

… destroyed. Signed-off-by: Chris Kulla <ckulla@gmail.com>
fpsunflower · Apr 12, 2024 · d7e1afe · d7e1afe
1 parent bab0860
commit d7e1afe
Show file tree

Hide file tree

Showing 4 changed files with 22 additions and 6 deletions.
diff --git a/src/libOpenImageIO/imageinput.cpp b/src/libOpenImageIO/imageinput.cpp
@@ -81,7 +81,11 @@ ImageInput::ImageInput()
 
 
 
-ImageInput::~ImageInput() {}
+ImageInput::~ImageInput() {
+    // Erase any leftover errors from this thread
+    // TODO: can we clear other threads' errors?
+    input_error_messages.erase(this);
+}
 
 
 

diff --git a/src/libOpenImageIO/imageoutput.cpp b/src/libOpenImageIO/imageoutput.cpp
@@ -84,7 +84,11 @@ ImageOutput::ImageOutput()
 
 
 
-ImageOutput::~ImageOutput() {}
+ImageOutput::~ImageOutput() {
+    // Erase any leftover errors from this thread
+    // TODO: can we clear other threads' errors?
+    output_error_messages.erase(this);
+}
 
 
 

diff --git a/src/libtexture/imagecache.cpp b/src/libtexture/imagecache.cpp
@@ -1722,6 +1722,9 @@ ImageCacheImpl::~ImageCacheImpl()
         spin_lock lock(m_perthread_info_mutex);
         m_all_perthread_info.clear();
     }
+    // Erase any leftover errors from this thread
+    // TODO: can we clear other threads' errors?
+    imcache_error_messages.erase(this);
 }
 
 

diff --git a/src/libtexture/texturesys.cpp b/src/libtexture/texturesys.cpp
@@ -351,8 +351,16 @@ TextureSystemImpl::init()
 }
 
 
+static thread_local tsl::robin_map<const TextureSystemImpl*, std::string>
+    txsys_error_messages;
 
-TextureSystemImpl::~TextureSystemImpl() { printstats(); }
+
+TextureSystemImpl::~TextureSystemImpl() {
+    printstats();
+    // Erase any leftover errors from this thread
+    // TODO: can we clear other threads' errors?
+    txsys_error_messages.erase(this);
+}
 
 
 
@@ -893,9 +901,6 @@ TextureSystemImpl::get_texels(TextureHandle* texture_handle_,
     return ok;
 }
 
-static thread_local tsl::robin_map<const TextureSystemImpl*, std::string>
-    txsys_error_messages;
-
 bool
 TextureSystemImpl::has_error() const
 {