Skip to content
This repository has been archived by the owner on Mar 31, 2023. It is now read-only.

Added attach_library Twig function in PL #229

Merged
merged 3 commits into from
May 11, 2018
Merged

Added attach_library Twig function in PL #229

merged 3 commits into from
May 11, 2018

Conversation

evanmwillhite
Copy link
Contributor

@evanmwillhite evanmwillhite commented May 10, 2018 •
edited
Loading

If you want to use this in PL files (which we do in new icon file), this function has to be added to Pattern Lab's _twig-components

How to test:

  1. Checkout this branch and run yarn start and make sure you get no errors
  2. Bonus points: Ensure it causes no issues in Drupal (I tested this)

amazingrando
amazingrando approved these changes May 11, 2018
View reviewed changes
Copy link
Member

@amazingrando amazingrando left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@evanmwillhite evanmwillhite merged commit 1cebd07 into develop May 11, 2018
@evanmwillhite evanmwillhite deleted the pl-attach-library branch May 11, 2018 14:02
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@amazingrando amazingrando amazingrando approved these changes

Assignees
No one assigned
Labels
Priority: Critical Status: Passes code review Status: Passes functional review Status: Shipit
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@evanmwillhite @amazingrando