Skip to content
This repository has been archived by the owner on Mar 31, 2023. It is now read-only.

Github Pages deployment fix #208

Merged
merged 2 commits into from
Mar 5, 2018
Merged

Github Pages deployment fix #208

merged 2 commits into from
Mar 5, 2018

Conversation

evanmwillhite
Copy link
Contributor

@evanmwillhite evanmwillhite commented Mar 5, 2018

Fixes github pages deployment script (gulp ghpages-deploy) by switching from gulp-gh-pages to gh-pages npm package. This PR merely ignores the build directory created by the script - the majority of the change is in fourkitchens/emulsify-gulp#74

To test:

  • Fork Emulsify and clone the new fork down locally
  • Open package.json and change fourkitchens/emulsify-gulp#v2.0.0 to fourkitchens/emulsify-gulp#pages-fix
  • yarn install
  • yarn start
  • gulp ghpages-deploy
  • Verify the gh-pages branch was created and push to your repo and that in your repo's settings, you can navigate to the Github Pages url + /pattern-lab/public and view the Pattern Lab instance.

Copy link
Collaborator

@ccjjmartin ccjjmartin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@evanmwillhite evanmwillhite merged commit 8d4ad43 into develop Mar 5, 2018
@evanmwillhite evanmwillhite deleted the pages-fix branch March 5, 2018 18:07
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants